-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding blur background or dim #8
Comments
Thank you for you kind words and your feedback.
Do you mean, that when the user drags the BottomSheet down (below the threshold) the BottomSheet dismisses itself? If yes it Is also already on my #7 list called “dragToDismiss”. The features to make the background blur and to stop the BottomSheet to go above 1 I will add on my list. |
Yes and yes .
Thanks
On Thu, May 27, 2021 at 1:00 PM Lucas Zischka ***@***.***> wrote:
Thank you for you kind words and your feedback.
The feature where you tap the background to dismiss the BottomSheet is
already on my list for the new version (see #7
<#7>) called “tapToDismiss”
and as soon as I have time I will implement it.
Just one question, what exactly do mean with:
Finally , it would be amazing to add threshold. E.g 0.234 it will dismiss
Do you mean, that when the user drags the BottomSheet down (below the
threshold) the BottomSheet dismisses itself? If yes it Is also already on
my #7 <#7> list called
“dragToDismiss”.
The features to make the background blur and to stop the BottomSheet to go
above 1 I will add on my list.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIEGG5EMUN33X2V2TB5BQXLTPYJ2FANCNFSM45TL5VQQ>
.
--
Best wishes Tariq Almazyad
|
I will now close this issue because all features have been implemented and fully documented (see #7 or the branch #new version). |
This fixes #8 because it no longer relies on `.disabled()` as it uses `Introspect` instead. This is only a temporary solution, as i don't want to rely on other packages and as im planning to port my own UIScrollView to SwiftUI. The custom port would fix this issue and could make other features on my ToDo List (see #11) possible.
Your library is one of the best in market !
It is better to add a parameter as optional to whether choose blur bg or dim so that the focus go to the bottom sheet when user open it .
Also , make the bg dismisses the bottom sheet when user touches it .
Finally , it would be amazing to add threshold. E.g 0.234 it will dismiss ,
I almost forgot , it would be also good if you make the bottom sheet does not go above 1.0 top (passing iPhone frame)
The text was updated successfully, but these errors were encountered: