Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onAppear only called once #65

Closed
flowbe opened this issue Jun 20, 2022 · 0 comments · Fixed by #79
Closed

onAppear only called once #65

flowbe opened this issue Jun 20, 2022 · 0 comments · Fixed by #79
Labels
bug Something isn't working

Comments

@flowbe
Copy link

flowbe commented Jun 20, 2022

When presenting a bottom sheet, the onAppear will be called the first time only. If the bottom sheet is hidden and shown again later, it won't be called
@lucaszischka lucaszischka added the bug Something isn't working label Jun 26, 2022
@lucaszischka lucaszischka added this to the v3 milestone Jul 4, 2022
@lucaszischka lucaszischka linked a pull request Jul 4, 2022 that will close this issue
BottomSheet v3 #79
Merged
@lucaszischka lucaszischka mentioned this issue Jul 4, 2022
Merged
lucaszischka added a commit that referenced this issue Aug 7, 2022
@lucaszischka
BottomSheet v3 (#79)
75b0143 
- Recoded the project
- Added iPhone landscape support
- Added iPad support
- Added MacOS support
- Changed from options to view modifiers
- Cleaned up the code (swiftLint and splitting it up)
- Added dynamic size support
- Added onDismiss modifier
- Added dragIndicatorAction modifier
- Added dragPositionSwitchAction modifier
- Added dragGesture listener
- Changed customBackground to not rely on AnyView
- Fixed onAppear only called once #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BottomSheet v3 lucaszischka/BottomSheet
2 participants
@flowbe @lucaszischka