Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit animation bug with NavigationView #31

Closed
artemelianov opened this issue Oct 21, 2021 · 2 comments · Fixed by #38
Closed

Implicit animation bug with NavigationView #31

artemelianov opened this issue Oct 21, 2021 · 2 comments · Fixed by #38
Labels
bug Something isn't working Thank You ❤️ For people who appreciate my work

Comments

@artemelianov
Copy link

Hi
Thanks for this amazing library!

I've found a new bug. If we embed this sheet at the start, we will see an implicit animation. First point of the view is .zero, so we can se the animation i suppose
Any ideas how to handle it?

RPReplay_Final1634830744.mov
@lucaszischka lucaszischka added bug Something isn't working Thank You ❤️ For people who appreciate my work labels Oct 21, 2021
@lucaszischka
Copy link
Owner

Hello, thank you for your kind words and for your bug report.

Would you mind to share some code for reproducing this behavior, to help me understanding what causes this bug and how to fix it.

Greetings Lucas

@artemelianov
Copy link
Author

Sure

We need to use SwiftUI app life cycle
Here is a simple example

@main
struct TestApp: App {
    var body: some Scene {
        WindowGroup {
           TestView()
        }
    }
}
struct TestView: View {
   var body: some View {
      NavigationView {
         ArtistSongsView()
      }
   }
}

lucaszischka added a commit that referenced this issue Dec 28, 2021
- Update Copyright
- Update swift-tools-version
- Update deprecated code (real fix for #19, replaces #20)
- Add `.absolutePositionValue` option (closes #37)
- Add `BottomSheetPositionAbsolute`
- Use explicit animations (fixes #31)
- Hide examples in ReadMe
- Implement and fix `.appleScrollBehavior` (closes #37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Thank You ❤️ For people who appreciate my work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants