-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-commit.ci test #2
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
4515d1d
to
8bdc3d0
Compare
Adding dummy non-formatted file to test. |
Looks ok. Adding another dummy file. |
Looks OK. Changing the style updates old files as well. Testing adding mixed file types and changing already existing files. |
C/C++ files looks ok. Black cannot always fix everything by itself (for example in dummy.py). When adding the python linter we will need to adjust some files manually. For files it can't fix, the CI will fail and show in the log where formatting errors were detected. Testing codespell. |
c2eb6fd
to
a1628df
Compare
Codespell works fine. Just need to be careful with false positives when updating the codebase by locally disabling the write flag and adding the false positives to the config file. |
1451bf0
to
5e32c38
Compare
Separated codespell config into a new file to make it more intuitive. Also delete pyproject and move black config as hook argument (as it was just one option). Need to investigate prettier and yamllint. |
d81b7c9
to
240ac9a
Compare
Prettier and yamllint looks properly configured. Testing in the entire codebase to check for any potential issues. |
807aad0
to
6a4d292
Compare
5f3384a
to
69f551e
Compare
69f551e
to
30f0e98
Compare
Testing of pre-commit.ci lite. Configured to run only in modified files.