fixing scroll for application switching. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasresck
approved these changes
Nov 13, 2022
|
Hi, @vakokako, thank you very much for your contribution! Based on my tests and on my reading of your and GNOME's code, this seems to really fix the problem. Thank you again for that. Because this project is under GPLv3, before accepting your PR you may want to add yourself in the copyright notice. |
|
Hey, not sure how to add myself to the copyright notice |
|
Just add another line in the beginning of or similar. But only if you desire to. |
vakokako
force-pushed
the
fixing_app_switch
branch
from
61f7362 to
1f57184
Compare
|
Sure, added it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2. I'm not super familiar with gnome extensions or javascript for that matter, so any suggestions would be welcomed :)