-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to overview + mouse click #25
Conversation
Fix scrolling bug when changing windows using overview (hot corner or Super key) + mouse click. Co-authored-by: lbltavares <[email protected]>
Just mentioning you: @lbltavares and @ld-web. |
When I install the extension from the terminal (both with and without overview support), GNOME crashes and I have to login again. Maybe it's a GNOME's problem and not the extension's. Have you experienced this? |
@lucasresck Does it crash the moment you install the extension or when reloading GNOME by pressing alt+f2 and typing 'r'? I was experiencing the latter, although it was not related to the extension (as it crashed even with all extensions turned off), but apparently when a window was open during reload. If that's your case, what worked for me was closing all open windows before reloading GNOME (it sucks for debugging, but yeah 😞 ). |
@lbltavares, it indeed crashes when reloading GNOME! Good to know it's not related to the extension then. My concern was because it didn't happen before GNOME 45. Thanks! |
The feature seems to be working properly. I'll merge this PR and continue testing the feature on Thanks, @lbltavares, for all support and help! |
Thank you so much for implementing this. It works perfectly for me on GNOME 44 and 45 and makes VSCode usable without tearing my hair out. <3 Edit: By the way, it's very unlikely that this will be fixed in GNOME itself. It's been 7+ years. But Wayland doesn't have this issue at all, and soon Wayland will be stable enough for daily usage by everyone. Some links with more info here: https://gitlab.gnome.org/GNOME/mutter/-/issues/401#note_2110232 |
Happy to help! <3
Yeah, there's been a few years already since the bug came back with stable Ubuntu 22.04. Not sure about Wayland though, I hope so... |
@lucasresck Yeah the input replication bug is only on X11. I had two reasons for being on X11:
Since then, Wayland has developed a lot and is now almost on par with what applications can do on X11, but with much more security (permission portals for everything). And NVIDIA has implemented most of the features now, including Night Light color support. More importantly, NVIDIA has finally gotten their wishes and Linux is now getting an Explicit Sync protocol which solves all of NVIDIA's issues on Wayland.
I'm saying this since I suspect that you're an NVIDIA user too. Most AMD users have no issues with Wayland. Our days of poor Wayland support are almost over. We just gotta wait for driver 555. As long as our distros ship GNOME 46.1, we're done. I'm on Fedora, which I can highly recommend since it's a super reliable and polished distro. They're on GNOME 46.1 now. It's easy to switch from Ubuntu to Fedora. So yeah, the remaining days of needing this great extension are numbered... ;) As soon as driver 555 is released and packaged for Fedora, I'm finally leaving X11 behind! |
Hi, @Arcitec, thank you for the detailed information. When I tried Wayland a few years ago, I would have problems with screen sharing in apps like Zoom. I hope we don't need an extension to use our computers in a decent way in the near future. Thanks for your perspective. |
@lucasresck Yeah, Wayland used to have so many issues. They've been working out most issues in the past 2 years. Like Zoom, which has native support for screensharing on Wayland since 2022: https://www.omglinux.com/zoom-linux-can-now-screenshare-wayland/ The only real stopper for Wayland has been NVIDIA's poor support for it, which is getting fixed now. NVIDIA missed the preliminary release date for driver 555, but it should be here soon, and then Fedora will release it a few weeks later, so I guess I'll be on Wayland within 1-2 months at the most. :) Maybe you even end up trying it in a dual boot, hehe. |
Fix scrolling bug when changing windows using overview (hot corner or Super key) + mouse click.
Co-authored by @lbltavares (#21 (comment)).
It works on my tests.