-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Recommendations for label syntax exclude underscores #362
Comments
Yeah I'd say Balena should fix it. They're being overly restrictive for no good reason. It's always worked with underscores 🤷♂️ |
This supports overly restrictive docker compose implementations lucaslorentz#362
I agree with you, however I'm at their mercy. Would you be interested in a PR with a small change support hyphens as a replacement for underscores? This seems like a pretty trivial change. The tests pass, but I'm not a caddy expert, are there any special cases we need to be sure to handle? |
That's gross. It really limits future use of |
I've submitted a support ticket, but given the age of that forum post, I'm not hopeful. |
The docker recommendations for label syntax say that "Label keys should begin and end with a lower-case letter and should only contain lower-case alphanumeric characters, the period character (.), and the hyphen character (-)." https://docs.docker.com/config/labels-custom-metadata/
I am trying to use Balena to deploy Caddy with some other services that it reverse proxies. The label "caddy.reverse_proxy" is invalid per the validation in the Balena tool.
My first thought is to allow "hyphens" where underscores are used and convert them before rendering the caddy file.
I'd appreciate any thoughts.
Related thread on Balena Forum: https://forums.balena.io/t/docker-compose-label-constraints/55756
The text was updated successfully, but these errors were encountered: