Added maximum string length constraint. (jenkinsci#449)

lucascz37 · Dec 5, 2023 · e175dc7 · e175dc7
1 parent 82fed4c
commit e175dc7
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 0 deletions.
diff --git a/src/main/java/net/masterthought/jenkins/CucumberReportDescriptor.java b/src/main/java/net/masterthought/jenkins/CucumberReportDescriptor.java
@@ -35,6 +35,10 @@ public FormValidation doCheckTrendsLimit(@QueryParameter String value) {
         return isValidInteger(value);
     }
 
+    public FormValidation doMaxStringLengthConstraint(@QueryParameter String value) {
+        return isValidInteger(value);
+    }
+
     public FormValidation doCheckFailedStepsNumber(@QueryParameter String value) {
         return isValidInteger(value);
     }

diff --git a/src/main/java/net/masterthought/jenkins/CucumberReportPublisher.java b/src/main/java/net/masterthought/jenkins/CucumberReportPublisher.java
@@ -12,6 +12,7 @@
 import java.util.Set;
 import java.util.UUID;
 
+import com.fasterxml.jackson.core.StreamReadConstraints;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import hudson.AbortException;
 import hudson.Extension;
@@ -78,6 +79,7 @@ public class CucumberReportPublisher extends Recorder implements SimpleBuildStep
     private boolean undefinedAsNotFailingStatus;
 
     private int trendsLimit;
+    private int maxStringLengthConstraint;
     private String sortingMethod;
     private List<Classification> classifications;
     private String customJsFiles;
@@ -158,6 +160,14 @@ public void setTrendsLimit(int trendsLimit) {
         this.trendsLimit = trendsLimit;
     }
 
+    public int getMaxStringLengthConstraint() {
+        return maxStringLengthConstraint;
+    }
+
+    public void setMaxStringLengthConstraint(int maxStringLengthConstraint) {
+        this.maxStringLengthConstraint = maxStringLengthConstraint;
+    }
+
     public String getFileExcludePattern() {
         return fileExcludePattern;
     }
@@ -559,6 +569,8 @@ private void generateReport(Run<?, ?> build, FilePath workspace, TaskListener li
 
         setFailingStatuses(configuration);
 
+        StreamReadConstraints.overrideDefaultStreamReadConstraints(StreamReadConstraints.builder().maxStringLength(maxStringLengthConstraint).build());
+
         ReportBuilder reportBuilder = new ReportBuilder(jsonFilesToProcess, configuration);
         Reportable result = reportBuilder.generateReports();
 

diff --git a/src/main/resources/net/masterthought/jenkins/CucumberReportPublisher/config.jelly b/src/main/resources/net/masterthought/jenkins/CucumberReportPublisher/config.jelly
@@ -33,6 +33,11 @@
                     field="trendsLimit">
                 <f:textbox default="0"/>
             </f:entry>
+            <f:entry
+                    title="${%maxStringLengthConstraint.title}"
+                    field="maxStringLengthConstraint">
+                <f:textbox default="20000000"/>
+            </f:entry>
         </f:section>
 
 

diff --git a/src/main/resources/net/masterthought/jenkins/CucumberReportPublisher/config.properties b/src/main/resources/net/masterthought/jenkins/CucumberReportPublisher/config.properties
@@ -6,6 +6,7 @@ fileIncludePattern.title=File Include Pattern
 classificationsFilePattern.title=Classifications File Pattern
 fileExcludePattern.title=File Exclude Pattern
 trendsLimit.title=Limit for trends
+maxStringLengthConstraint.title=Maximum string size (Stream read constraint of JacksonCore)
 # ===
 buildResult=Build Result
 buildResult.description=This section allows to configure when the build is marked as failed or unstable. Result is changed when any of below rule is enabled.