-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker container for easier usage #6
Conversation
I've migrated this project to use .NET 8 instead of .NET 5, if you make an amended commit to use the .NET 8 version of this Docker container I would be more than happy to merge it. Thank you for your contribution! |
b4a3ea4
to
35982e8
Compare
35982e8
to
e1d8a57
Compare
@@ -33,7 +33,7 @@ interface BytecodeDefinitionFile { | |||
|
|||
const fileExists = async (path: string) => !!(await fs.stat(path).catch((_) => false)); | |||
|
|||
const outputDirectory = path.join(lspDir, 'bin', 'Debug', 'net5.0'); | |||
const outputDirectory = path.join(lspDir, 'bin', 'Debug', 'net8.0'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oversight?
@lucasbaizer2 Looks like enabling AOT broke building in Docker. See my comments above. |
@lucasbaizer2 Are you OK with disabling AOT that was introduced with the migration from NET 5.0 → NET 8.0? If yes then you can merge my PR as is, it already contains the needed change. Edit: hasmer definitely doesn't support AOT because among other things it uses reflection. The
|
Thanks for the change! |
No description provided.