Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 #310

Merged
merged 2 commits into from
Jun 11, 2020
Merged

V5 #310

merged 2 commits into from
Jun 11, 2020

Conversation

lucas34
Copy link
Owner

@lucas34 lucas34 commented May 25, 2020

JobConstraint is now public

TODO.

There is an issue with deserialising constraint that are always being added

@github-actions
Copy link

1 Warning
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #310 into master will increase coverage by 1.02%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   89.01%   90.03%   +1.02%     
==========================================
  Files          35       38       +3     
  Lines        1793     1786       -7     
==========================================
+ Hits         1596     1608      +12     
+ Misses        197      178      -19     
Impacted Files Coverage Δ
Sources/SwiftQueue/Constraint.swift 100.00% <ø> (ø)
Tests/SwiftQueueTests/BackgroundTasksTest.swift 0.00% <0.00%> (ø)
Sources/SwiftQueue/SwiftQueueManager.swift 81.52% <20.00%> (-2.93%) ⬇️
Sources/SwiftQueue/Constraint+Tag.swift 92.85% <92.85%> (ø)
Sources/SwiftQueue/JobInfo.swift 95.83% <94.11%> (-4.17%) ⬇️
Sources/SwiftQueue/JobBuilder.swift 93.42% <95.23%> (+2.75%) ⬆️
Sources/SwiftQueue/Constraint+Persister.swift 100.00% <100.00%> (ø)
Sources/SwiftQueue/ConstraintMaker.swift 100.00% <100.00%> (ø)
...urces/SwiftQueue/JobInfoSerializer+Decodable.swift 81.81% <100.00%> (-13.69%) ⬇️
Sources/SwiftQueue/SqOperation.swift 94.23% <100.00%> (+2.15%) ⬆️
... and 17 more

@lucas34 lucas34 force-pushed the v5 branch 28 times, most recently from f4ad580 to 2698fc5 Compare May 26, 2020 20:26
@lucas34 lucas34 force-pushed the v5 branch 22 times, most recently from fec5058 to ce01288 Compare May 30, 2020 12:20
@lucas34 lucas34 force-pushed the v5 branch 3 times, most recently from 2a9e3c6 to c68e689 Compare June 8, 2020 19:17
@lucas34 lucas34 merged commit e0e80c8 into master Jun 11, 2020
@lucas34 lucas34 deleted the v5 branch June 11, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant