Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-C locale issues in REPL #474

Merged
merged 2 commits into from
May 4, 2022
Merged

Fix non-C locale issues in REPL #474

merged 2 commits into from
May 4, 2022

Conversation

byte-chan
Copy link
Contributor

This fixes #473 by resetting the locale to C after calling ic_set_default_completer (which eventually calls setlocale(LC_ALL,"")) in runReplImpl.

zeux
zeux approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@zeux zeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zeux zeux merged commit 9156b5a into luau-lang:master May 4, 2022
@zeux zeux mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeux zeux zeux approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REPL fails to parse decimal numbers in some locales
2 participants
@byte-chan @zeux