Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting sandbox on Lua instance without strlib #1156

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix setting sandbox on Lua instance without strlib #1156

merged 1 commit into from
Jan 30, 2024

Conversation

khvzak
Copy link
Contributor

@khvzak khvzak commented Jan 29, 2024

Currently calling luaL_sandbox on Lua instance without loaded strlib causes crash (assertion).
It happens because inside luaL_sandbox there is no check that metatable for strings is present.

@vegorov-rbx vegorov-rbx merged commit d409f79 into luau-lang:master Jan 30, 2024
6 checks passed
@vegorov-rbx
Copy link
Collaborator

Thank you.

@khvzak khvzak deleted the fix_sandbox branch January 31, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegorov-rbx vegorov-rbx vegorov-rbx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khvzak @vegorov-rbx