Implement grouped mode for find_nodes_in_area #9888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good feature, thanks sfan5. |
|
If anyone feels like testing: it would be interesting to know if this is faster than using a vmanip to read all nodes and then iterating them in Lua. |
SmallJoker
reviewed
Jul 1, 2020
LoneWolfHT
reviewed
Jul 14, 2020
| * First return value: Table with all node positions | ||
| * Second return value: Table with the count of each node with the node name | ||
| as index. | ||
| * If `grouped` is true the return value is a table indexed by node name |
There was a problem hiding this comment.
Can the node name be something like 'group:lava' if that was the nodename provided?
There was a problem hiding this comment.
No, the names returned are always nodes even if you put in a group.
There was a problem hiding this comment.
Hmmm, I guess a modder could use minetest.get_item_group() if they wanted to apply to all nodes in a certain group.
I have no problems with this then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usecase: luanti-org/minetest_game#2683
To do
This PR is Ready for Review.