Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48282: Refactor obscore to allow subclasses #1142

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

timj
Copy link
Member

@timj timj commented Jan 15, 2025

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

@timj timj requested a review from andy-slac January 15, 2025 18:39
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 68.86792% with 33 lines in your changes missing coverage. Please review.

Project coverage is 89.46%. Comparing base (524ffd8) to head (a7af72e).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ython/lsst/daf/butler/registry/obscore/_records.py 67.64% 23 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
- Coverage   89.49%   89.46%   -0.04%     
==========================================
  Files         366      366              
  Lines       49018    49068      +50     
  Branches     5941     5950       +9     
==========================================
+ Hits        43870    43897      +27     
- Misses       3733     3753      +20     
- Partials     1415     1418       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing that I'm not sure about is whether it's easier to specify record factory type in obscore config vs. entry point.

python/lsst/daf/butler/registry/obscore/_records.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/registry/obscore/_records.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/registry/obscore/_records.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/registry/obscore/_records.py Outdated Show resolved Hide resolved
@timj timj force-pushed the tickets/DM-48282 branch from 4658af5 to af14982 Compare January 17, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants