This repository has been archived by the owner on Jan 4, 2024. It is now read-only.
DM-40638: Convert to Safir's AsyncMultiQueue #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will alas have to wait until we have a JupyterHub that runs under Python 3.11. Unfortunately, they're using Ubuntu 22.04 as the base for even JupyterHub 4, which only comes with Python 3.10. |
Use the AsyncMultiQueue data structure from Safir to manage the progress events. This is a richer version of the data structures that were being used internally. Rely on the spawner calling end() in its finally block and don't poll the spawner task for completion inside the progress iterator. The Safir AsyncMultiQueue has a mechanism for explicitly indicating the end of the data in the queue, which should serve the same purpose. Simplify the way that progress events are checked in the test suite and add an explicit test for reading the events of a spawn after the spawn has completed.
rra
force-pushed
the
tickets/DM-40638
branch
from
3d83860 to
396079b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the AsyncMultiQueue data structure from Safir to manage the progress events. This is a richer version of the data structures that were being used internally.
Rely on the spawner calling end() in its finally block and don't poll the spawner task for completion inside the progress iterator. The Safir AsyncMultiQueue has a mechanism for explicitly indicating the end of the data in the queue, which should serve the same purpose.
Simplify the way that progress events are checked in the test suite and add an explicit test for reading the events of a spawn after the spawn has completed.