DM-44397: Mobu: disable running existing notebooks in subdirs #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fajpunk
force-pushed
the
tickets/DM-44397/mobu-notebook-directories
branch
from
f86c7f0 to
ef84e25
Compare
rra
reviewed
May 20, 2024
| This uses the business ``NotebookRunner`` instead, which checks out a Git repository and runs all notebooks at the top level of that repository. | ||
| This uses the business ``NotebookRunner`` instead, which checks out a Git repository and runs all notebooks in that repository, at the top level and any directories and subdirectories, except: | ||
|
|
||
| * Notebooks in the ``mobu_exclude`` directory will never be executed. |
There was a problem hiding this comment.
If you agree with my comment on the mobu diff, also remove this sentence.
| This uses the business ``NotebookRunner`` instead, which checks out a Git repository and runs all notebooks in that repository, at the top level and any directories and subdirectories, except: | ||
|
|
||
| * Notebooks in the ``mobu_exclude`` directory will never be executed. | ||
| * ``options.exclude_dirs`` tells mobu to not excecute any notebooks in those directories or any descendant directories. |
There was a problem hiding this comment.
You have this line twice, here and below. I think delete this one and keep the one below?
fajpunk
force-pushed
the
tickets/DM-44397/mobu-notebook-directories
branch
from
d4b04e9 to
5efd9bc
Compare
rra
approved these changes
May 20, 2024
| The repository URL and branch are configured in ``options``. | ||
| ``options.max_executions: 1`` tells mobu to shut down and respawn the pod after each notebook. | ||
| This exercises pod spawning more frequently, but does not test the lab's ability to run a long series of notebooks. | ||
| Those directories are relative to the repo root. |
There was a problem hiding this comment.
This sentence seems to be in the wrong spot. I think it was supposed to be after exclude_dirs below.
fajpunk
force-pushed
the
tickets/DM-44397/mobu-notebook-directories
branch
2 times, most recently
from
e6947ee to
cd4d238
Compare
fajpunk
force-pushed
the
tickets/DM-44397/mobu-notebook-directories
branch
from
cd4d238 to
0f9384e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsst-sqre/mobu#347 changes the Mobu notebook runner business to run all notebooks in all subdirs by default. This PR prevents any changes in behavior to existing flocks.