DM-36868: Clean up the sqlproxy service #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
force-pushed
the
tickets/DM-36868
branch
4 times, most recently
from
25e895f to
fc69faf
Compare
|
The docs build is failing because of a link to a page that is also created by this PR, so should resolve once it's merged. |
athornton
approved these changes
Nov 8, 2022
| @@ -2,31 +2,28 @@ | |||
| apiVersion: v1 | |||
| kind: Namespace | |||
| metadata: | |||
| name: sqlproxy-cross-project | |||
| name: "sqlproxy-cross-project" | |||
There was a problem hiding this comment.
I don't understand why you're quoting all the strings in this file, when we don't elsewhere, but it seems unlikely to hurt anything.
There was a problem hiding this comment.
I've been adding quoting to each file in Phalanx when I touch it because it means one doesn't have to remember YAML's quoting rules, but I admit that I'm inconsistent about it. (A bunch of the applications have already been converted to fully quoted, though, so this is making them more consistent.)
Rename this to sqlproxy-cross-project to match the science-platform name and overall Phalanx configuration. Add documentation. Clean up the Helm chart configuration. Remove a bunch of unneeded variables and make the interface higher-level, roughly matching how Gafaelfawr's instance of this has been configured. Remove global variables that were never used.
Otherwise, we create a deadlock that causes the new docs to never be published.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename this to sqlproxy-cross-project to match the science-platform name and overall Phalanx configuration. Add documentation.
Clean up the Helm chart configuration. Remove a bunch of unneeded variables and make the interface higher-level, roughly matching how Gafaelfawr's instance of this has been configured. Remove global variables that were never used.
Update the minikube and Kubernetes versions used for testing.