DM-38339: Update to latest Safir, use Settings for config #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use current_datetime and format_datetime_for_logging rather than rolling our own versions.
Use the Pydantic Settings class for configuration instead of a dataclass with os.getenv initializers. Fix the typing of URLs to validate syntax, which unfortunately requires allowing None for the test suite and adding more verification elsewhere. Be a bit more robust in URL construction to allow for trailing slashes in the configured URLs. Switching the type to HttpUrl requires doing some weird things to override the defaults in fixtures, but this is apparently the correct Pydantic way of doing it.
Use enums for the configure_logging call and hard-code the production logging syntax. Also configure Uvicorn logging to match.
On second thought, re-add the logging profile configuration and default to development. We'll change the default to production in Phalanx. The development logger makes it easier to understand test output.
When constructing the loc part of the error detail, use the enum provided by Safir.
Don't turn Uvicorn logs to JSON if we're not using JSON for the rest of our logs.
We have to spawn an external application for monkeyflocker testing. Use Safir's spawn_uvicorn rather than rolling our own, and use the factory approach so that we can get proper type checking and black formatting of the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current_datetimeandformat_datetime_for_loggingfrom SafirSettingsand do more validation of inputspawn_uvicornto start a process for monkeyflocker testing