DM-47716: Move token cache transaction management #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
force-pushed
the
tickets/DM-47716
branch
from
63c97e1 to
7b8c294
Compare
The pattern of doing database transaction management within the handlers meant that a database transaction was created in the hot path of ingress auth requests if delegated tokens were requested. Move the transaction management into the token cache service so that the transaction is only created if database activity is required.
rra
force-pushed
the
tickets/DM-47716
branch
from
7b8c294 to
45d623d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern of doing database transaction management within the handlers meant that a database transaction was created in the hot path of ingress auth requests if delegated tokens were requested. Move the transaction management into the token cache service so that the transaction is only created if database activity is required.