Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM spec file for lsd #901

Merged
merged 8 commits into from
Nov 24, 2023
Merged

RPM spec file for lsd #901

merged 8 commits into from
Nov 24, 2023

Conversation

danie-dejager
Copy link
Contributor

Basic SPEC file that can be used to build a RPM for lsd.

  • UPX compression was disabled.

I have precompiled packages on my fork for EL9 and AMZN AL2023.
https://github.com/daniejstriata/lsd/releases

SPEC file that can be used to build RPM for lsd. 
  - UPX compression was disabled.
@muniu-bot
Copy link

muniu-bot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daniejstriata

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot added the size/S label Sep 25, 2023
@zwpaper
Copy link
Member

zwpaper commented Sep 28, 2023

hi @daniejstriata, thanks for the contribution, can you also add a ci to build the rpm? so that the spec file could be used and we could maintain a rpm release

@danie-dejager
Copy link
Contributor Author

hi @daniejstriata, thanks for the contribution, can you also add a ci to build the rpm? so that the spec file could be used and we could maintain a rpm release

Hi @zwpaper I've not built rpms before using ci on github. I'll investigate it.

@muniu-bot muniu-bot bot added size/M and removed size/S labels Nov 22, 2023
fixed source filename
@zwpaper
Copy link
Member

zwpaper commented Nov 22, 2023

hi @daniejstriata, how is this PR going? maybe we could merge it first if the spec is completed.

and let the ci be another PR

@danie-dejager
Copy link
Contributor Author

danie-dejager commented Nov 24, 2023

@zwpaper I've built lsd in copr here
https://copr.fedorainfracloud.org/coprs/faramirza/lsd/
for various rpm based distros. The difference between the spec I put here and the one in my fork is that the on I'm pushing here assumes that rust and cargo is already installed whereas the other version will install the version for rust available to the distro in its repos.

I'm still unsure about the ci on github. I've never used it before. I've not yet been able to look into that. Do you know of a recommend Guide I can look at?

We could cancel this PR and redo it once more with the newer spec?

@zwpaper
Copy link
Member

zwpaper commented Nov 24, 2023

let's merge this one and you could always work on the CI later, for CI, please check: https://github.com/features/actions

thanks for the contribution!

@zwpaper zwpaper merged commit 0fa2ca2 into lsd-rs:master Nov 24, 2023
@danie-dejager
Copy link
Contributor Author

@zwpaper I had a look. How is the Fedora package built and should that SPEC file not be added back here rather than mine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants