Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crossterm to 0.24.0 #688

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Bump crossterm to 0.24.0 #688

merged 2 commits into from
Jul 5, 2022

Conversation

meain
Copy link
Member

@meain meain commented Jul 3, 2022

Fixes #675
Fixes #657


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

This was initially pinned because of clap-rs/clap/issues/2691, but we
use a newer version as MSRV as of now in CI.
@meain meain requested a review from Peltoche as a code owner July 3, 2022 16:34
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #688 (244aa67) into master (2ffb59c) will decrease coverage by 0.15%.
The diff coverage is 24.24%.

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   88.32%   88.16%   -0.16%     
==========================================
  Files          41       41              
  Lines        4607     4539      -68     
==========================================
- Hits         4069     4002      -67     
+ Misses        538      537       -1     
Impacted Files Coverage Δ
src/color/theme.rs 62.19% <24.24%> (-9.78%) ⬇️
src/meta/date.rs 94.57% <0.00%> (-3.99%) ⬇️
src/meta/mod.rs 41.60% <0.00%> (-0.59%) ⬇️
src/meta/name.rs 89.10% <0.00%> (-0.49%) ⬇️
src/meta/permissions.rs 92.56% <0.00%> (-0.47%) ⬇️
src/meta/indicator.rs 97.14% <0.00%> (-0.36%) ⬇️
src/display.rs 91.93% <0.00%> (+0.88%) ⬆️
src/meta/filetype.rs 82.85% <0.00%> (+1.54%) ⬆️
src/meta/size.rs 96.96% <0.00%> (+1.56%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ffb59c...244aa67. Read the comment docs.

@meain meain force-pushed the update-crossterm branch from a3c135d to 244aa67 Compare July 5, 2022 07:20
@meain meain merged commit 5431651 into lsd-rs:master Jul 5, 2022
@meain meain deleted the update-crossterm branch July 5, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect display of file names in Windows 10 Color output is broken in some combinations on Windows + MSYS2
2 participants