Chore: Fix window insets usage
#345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-wls
approved these changes
Jan 28, 2025
FelberMartin
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
This is a followup to #320. This PR fixes the usage of WindowInsets in the context of the ReplyTextField.
Changes
WindowInsets.systembarsand use thenavigationBarsPadding()at the proper composables further down the UI tree.MetisPostListHandleras it messed with the padding values (probably because this scaffold was nested inside another scaffold)Steps for testing
Ensure that the paddings around the ReplyTextField are not behaving weirdly. Test with different navigation modes (gesture navigation, 3 buttonnavigation)