Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement
: Redesign & restructure chat textfield #320Improvement
: Redesign & restructure chat textfield #320Changes from 1 commit
2c27ef9
4947ff5
28b9886
70ea28c
d3452a6
755da3d
db76c2e
fcef4d6
b40f441
5b82b91
25e98fe
570bdf6
5916563
6522639
f7c9642
63a3fda
f78387b
38bd50c
5da58d7
6bb287a
b0afc01
2d5b112
a0107cf
ce00cb4
c064ee0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Unchanged files with check annotations Beta
Check failure on line 145 in feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/reply/MarkdownTextField.kt
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest ► test GIVEN the textField WHEN entering a non-tag character THEN the autoCompletion dialog is hidden
Raw output
Check failure on line 145 in feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/reply/MarkdownTextField.kt
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest ► test GIVEN the autoCompletion dialog WHEN removing the tag character @ THEN the autoCompletion dialog is hidden
Raw output
Check failure on line 145 in feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/reply/MarkdownTextField.kt
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest ► test GIVEN the autoCompletion dialog WHEN clicking an entry THEN the replacement is inserted into the textField and the dialog is hidden
Raw output
Check failure on line 145 in feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/reply/MarkdownTextField.kt
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest ► test GIVEN an empty reply textField WHEN doing nothing THEN the autoCompletion dialog is hidden
Raw output
Check failure on line 145 in feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/reply/MarkdownTextField.kt
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest ► test GIVEN an empty reply textField WHEN entering the tag character @ THEN a list of autoCompletionHints for users shows
Raw output
Check failure on line 145 in feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/reply/MarkdownTextField.kt
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest ► test GIVEN the textField WHEN entering a first and surname separated by a single whitespace THEN the dialog shows
Raw output
Check failure on line 145 in feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/reply/MarkdownTextField.kt
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest ► test GIVEN the autoCompletion has been performed WHEN entering the tag character again THEN the autoCompletion dialog shows again
Raw output
Check failure on line 145 in feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/reply/MarkdownTextField.kt
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldUiTest ► test GIVEN the textField WHEN entering a second whitespace THEN the dialog is hidden
Raw output
Check failure on line 145 in feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/reply/MarkdownTextField.kt
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldVisibilityUITest ► test GIVEN the chat list containing three posts is shown WHEN the markdown text field is clicked THEN the keyboard is shown below the markdo...
Raw output
Check failure on line 145 in feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/reply/MarkdownTextField.kt
de.tum.informatics.www1.artemis.native_app.feature.metis.conversation.ui.reply.ReplyTextFieldVisibilityUITest ► test GIVEN the thread view is shown containing one post and three answer posts WHEN the markdown text field is clicked THEN the keyboard is ...
Raw output