Development: Speedup loading of exercises in course management

[Strohgelaender]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I strictly followed the server coding and design guidelines.
• I documented the Java code using JavaDoc style.

Motivation and Context

After upgrading Hibernate, we experienced long loading times when opening the programming exercise details. This was caused by a query loading a lot of feedbacks, which in turn only got used for a isEmpty() check on the list.

Description

I replaced the query with a boolean exists check.

Steps for Testing

code review

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

[coderabbitai]

Walkthrough

The recent updates introduce new methods in the FeedbackRepository interface to check for feedback based on grading instruction IDs and exercise grading criteria. Additionally, the ExerciseService class has been modified to use these new methods for determining if structured grading instruction feedback is used, enhancing the efficiency and clarity of feedback checks.

Changes

File Path	Change Summary
src/main/java/de/tum/in/www1/artemis/repository/FeedbackRepository.java	Added methods hasFeedbackFromGradingInstructionIds and hasFeedbackByExerciseGradingCriteria to check feedback presence.
src/main/java/de/tum/in/www1/artemis/service/ExerciseService.java	Modified checkExerciseIfStructuredGradingInstructionFeedbackUsed to use the new feedback checking methods.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant ExerciseService
    participant FeedbackRepository

    ExerciseService->>FeedbackRepository: hasFeedbackByExerciseGradingCriteria(gradingCriteria)
    FeedbackRepository-->>ExerciseService: boolean hasFeedback
    ExerciseService->>Exercise: setGradingInstructionFeedbackUsed(hasFeedback)

Loading

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 313f65e and 46209cf.

Files selected for processing (1)

• src/main/java/de/tum/in/www1/artemis/repository/FeedbackRepository.java (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/main/java/de/tum/in/www1/artemis/repository/FeedbackRepository.java

---

Tip

Early Access Features

• gpt-4o model for chat

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to full the review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[krusche]

Code changes look good 👍

[marlon-luca-bu]

Code looks good 👍

[sarpsahinalp]

code lgtm