Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Upgrade to Angular 14 and Jest 28 #5202

Merged
merged 18 commits into from
Jul 7, 2022
Merged

Development: Upgrade to Angular 14 and Jest 28 #5202

merged 18 commits into from
Jul 7, 2022

Conversation

bassner
Copy link
Member

@bassner bassner commented Jun 5, 2022 •
edited by ge65cer
Loading

Checklist

General

Client

Motivation and Context

Upgrade to new major versions of Angular and Jest.

Description

  • Bumped dependencies
  • Updated form builder stuff

Status

We're currently waiting for

@bassner bassner added blocked dependencies Pull requests that update a dependency file client Pull requests that update TypeScript code. (Added Automatically!) chore labels Jun 5, 2022
@bassner bassner self-assigned this Jun 5, 2022
@github-actions github-actions bot added the tests label Jun 5, 2022
@bassner bassner force-pushed the chore/angular-14 branch from 01aad13 to c0aa9e8 Compare June 13, 2022 12:17
@ge65cer
Copy link
Contributor

ge65cer commented Jul 1, 2022

We no longer use ngx-device-detector. 🙂
c01d5d7

@krusche
Copy link
Member

krusche commented Jul 2, 2022

I suggest we change from ngx-infinite-scroll to use virtual scrolling with fetching as implemented in angular material, see e.g. https://zoaibkhan.com/blog/create-a-fast-infinite-scrolling-list-in-angular/

The benefit would be that angular material is maintained with angular, so we don't have external dependencies for which we need to wait

@krusche
Copy link
Member

krusche commented Jul 2, 2022

There seems to be a 13.0.0-beta.1 which ng-bootstrap which we can try out and see if it works in our case

@bassner
Copy link
Member Author

bassner commented Jul 4, 2022 •
edited
Loading

Seems like the PR upgrading ngx-infinite-scroll just updates the dependency declarations and does not change anything on the code, so we can just try to override their peer deps for now

@bassner
Copy link
Member Author

bassner commented Jul 4, 2022 •
edited
Loading

I've added the beta version of ng-bootstrap. This should work as the only breaking change noted in the change log is the removal of already depreacted button directives which we don't seem to use.

@bassner bassner force-pushed the chore/angular-14 branch from a5658f3 to 6ca6478 Compare July 5, 2022 16:18
@bassner bassner temporarily deployed to artemistest5 July 5, 2022 19:30 Inactive
@bassner bassner marked this pull request as ready for review July 7, 2022 07:43
@bassner bassner requested a review from a team as a code owner July 7, 2022 07:43
ge65cer
ge65cer reviewed Jul 7, 2022
View reviewed changes
Copy link
Contributor

@ge65cer ge65cer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Bootstrap upgrade seems to have slightly broken the layout of the course cards.
Edit: @mallgaier found the issue to be from changes in #3764

Screenshot Screenshot 2022-07-07 at 14 08 49

Dominik-Weinzierl
Dominik-Weinzierl approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@Dominik-Weinzierl Dominik-Weinzierl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 worked as expected during the testing session

willergeorg
willergeorg approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@willergeorg willergeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested during testing session. Lgtm. 👍

ge65cer
ge65cer approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@ge65cer ge65cer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not find any other issues with the upgraded dependencies.

mallgaier
mallgaier approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@mallgaier mallgaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during testing session

@krusche krusche added this to the 5.9.0 milestone Jul 7, 2022
@krusche krusche merged commit 97a3a81 into develop Jul 7, 2022
@krusche krusche deleted the chore/angular-14 branch July 7, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ge65cer ge65cer ge65cer approved these changes

@mallgaier mallgaier mallgaier approved these changes

@willergeorg willergeorg willergeorg approved these changes

@Dominik-Weinzierl Dominik-Weinzierl Dominik-Weinzierl approved these changes

Assignees

@bassner bassner

Labels
chore client Pull requests that update TypeScript code. (Added Automatically!) dependencies Pull requests that update a dependency file ready to merge tests
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@bassner @ge65cer @krusche @Dominik-Weinzierl @willergeorg @mallgaier