Development: Fix modeling assessment for e2e tests
#10298
Conversation
github-actions
bot
added
the
client
Anishyou
changed the title
Development:Fixing Modeling Exercise for e2e testsDevelopment: Fixing Modeling Assesment for e2e tests
WalkthroughThe pull request revises the modeling assessment component by restructuring its HTML and updating its CSS. In the HTML template, an unnecessary outer container is removed and the conditional rendering order is modified while preserving existing checks for title, display points, draggable options, and explanation editing. The SCSS file sees several style adjustments, including removal of the parent-container class and updates to layout properties, flex settings, and responsiveness for key component elements. Changes
Sequence Diagram(s)sequenceDiagram
participant C as Component
participant T as Title
participant P as Points
participant D as Draggable Options
participant E as Explanation Editor
C->>T: Check if title exists
alt Title exists
T-->>C: Render title
end
C->>P: Check if displayPoints enabled
alt displayPoints true
P-->>C: Render points
end
C->>D: Render horizontal resize option
D-->>C: Horizontal option rendered
C->>D: Render vertical resize option
D-->>C: Vertical option rendered
C->>E: Check if explanation provided
alt Explanation provided
E-->>C: Render explanation editor
end
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/main/webapp/app/exercises/modeling/assess/modeling-assessment.component.scss (2)
19-21: Redundant Variable Declaration in .resizable Block
Within the .resizable block, the variable $draggable-width is re-declared with the same value as the global declaration. If this local override is not intended for specialized nested usage, consider removing it to avoid confusion. If there is a specific purpose, adding a clarifying comment would help future maintainers.
33-41: Print Media Query Adjustments
The media query block effectively adapts the .modeling-assessment container for print, setting height: auto and a max-height of 100vh with !important overrides. Although the use of !important is acceptable in this context, please double-check that these overrides do not conflict with other print styles.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/main/webapp/app/exercises/modeling/assess/modeling-assessment.component.html(1 hunks)src/main/webapp/app/exercises/modeling/assess/modeling-assessment.component.scss(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (7)
src/main/webapp/app/exercises/modeling/assess/modeling-assessment.component.scss (3)
3-17: Flex and Header Style Enhancements in .modeling-assessment
The updated .modeling-assessment class now explicitly uses a relative position and flex display with a column layout. The nested .card-header block’s styling (justify-content, width, font-size, and font-weight) appears well-aligned with typical UI header expectations. Please verify that these values match the client’s design standards.
23-26: Consistent Sizing Applied to .apollon-container
The updates in the .apollon-container block, enforcing both height and width of 100%, ensure that the container takes full available space. This approach is clean and consistent with typical layout practices.
28-31: Updated .apollon-row Flex Settings
The .apollon-row block now explicitly sets the height to 100% while maintaining a flex layout, which should provide a consistent behavior across various viewports.src/main/webapp/app/exercises/modeling/assess/modeling-assessment.component.html (4)
1-12: Simplified Container and Header Rendering
The outer container has been streamlined by directly using the "modeling-assessment" class (with conditional "resizable" binding), and the removal of the unnecessary outer "parent-container" div simplifies the DOM structure. The conditional rendering for title and displayPoints within the header is clear and uses the new Angular @if syntax, which matches the updated coding guidelines.
13-20: Apollon Row and Horizontal Resize Block
The restructuring of the .apollon-row section—with the embedded editor container and conditional horizontal resize control (displaying a draggable handle via the faGripLinesVertical icon)—improves readability and aligns with the new layout. Please ensure that the new conditional blocks (using @if) are correctly processed by the Angular compiler.
21-25: Vertical Resize Control Rendering
The conditional rendering for the vertical resize option is concise and mirrors the horizontal case appropriately. The structure and component placement here look solid.
26-28: Conditional Explanation Editor Integration
The inclusion of the jhi-modeling-explanation-editor component, based on the presence of the explanation variable, cleanly maintains functionality in a less nested layout. This change ensures that the explanation editor is rendered appropriately under the new structure.
krusche
changed the title
Development: Fixing Modeling Assesment for e2e testsDevelopment: Fix modeling assessment for e2e tests
|
I reverted the original commit directly on |
ok thank you |
Checklist
General
Client
Motivation and Context
Description
Reverting changes done in PR: #10145 as 4 of the e2e tests were not passing
Steps for Testing
Run develop branch for e2e tests.(https://bamboo.ase.in.tum.de/browse/ARTEMIS-AEPTMA)
Run this branch for e2e tests
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
Summary by CodeRabbit