Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Automatic Student Feedback Documentation #10272

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

LeonWehrhahn
Copy link
Contributor

@LeonWehrhahn LeonWehrhahn commented Feb 5, 2025

Checklist

General

Motivation and Context

Currently there is no documentation regarding the new Automatic Student Feedback.

Description

This PR introduces a new documentation section for Automatic Student Feedback within the Modeling Exercise documentation. The new section is structured to be consistent with other sections and provides:

  • A short overview of the feature
  • Step-by-step instructions on how to setup, request and view automatic feedback
  • Details on viewing feedback in the submission history.
  • A screencast that demonstrates the new feature

Steps for Testing

  1. Open the updated modeling.rst file in the local documentation build and check that the new Automatic Student Feedback is there and adheres to the documentation guidelines

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Performance Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

Copy link

coderabbitai bot commented Feb 5, 2025

Walkthrough

A new section titled "Automatic Student Feedback" has been added to the docs/user/exercises/modeling.rst file. This section explains the process of requesting and viewing AI-generated feedback for modeling exercises. It outlines the steps involved—from diagram creation and submission through to feedback analysis by the Athena Service—and details elements like notifications, preliminary scoring, and the availability of feedback history.

Changes

File(s) Changes Summary
docs/.../modeling.rst Added a new section "Automatic Student Feedback" detailing the process of requesting, receiving, and reviewing AI-generated feedback for modeling exercises via the Athena Service.

Sequence Diagram(s)

sequenceDiagram
    participant Student as User
    participant UI as Modeling Exercise Page
    participant Athena as Athena Service
    participant Notify as Notification System

    Student->>UI: Create diagram and submit feedback request
    UI->>Athena: Send diagram for feedback analysis
    Athena-->>UI: Return preliminary score and detailed feedback
    UI->>Notify: Trigger feedback ready notification
    Notify-->>Student: Display feedback and feedback history
Loading

Possibly related PRs

Suggested labels

documentation, ready for review, small

Suggested reviewers

  • krusche
  • maximiliansoelch
  • EneaGore

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
docs/user/exercises/modeling.rst (3)

276-285: Step-by-Step Instructions for Requesting Feedback
The "How to Request Automatic Feedback:" section is well structured with a numbered list and a container directive. Each step is clear. As a nitpick, please double-check that the directive’s indentation and formatting are consistent with similar sections in the document to maintain stylistic uniformity.


315-326: Submission History Documentation
The "Submission History" section clearly conveys how students can review previous feedback. As a minor suggestion, consider adding a brief note if there are any prerequisites or specific conditions under which the submission history is available.


327-330: Demo Section Enhancement
The Demo section effectively points to the screencast demonstration. For added clarity, consider briefly stating what users should expect to learn or observe from the demo.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d2d1c5 and dad50ce.

⛔ Files ignored due to path filters (5)
  • docs/user/exercises/modeling/automatic-feedback-history.png is excluded by !**/*.png, !**/*.png
  • docs/user/exercises/modeling/automatic-feedback-request-alert.png is excluded by !**/*.png, !**/*.png
  • docs/user/exercises/modeling/automatic-feedback-request-editor.png is excluded by !**/*.png, !**/*.png
  • docs/user/exercises/modeling/automatic-feedback-request-score.png is excluded by !**/*.png, !**/*.png
  • docs/user/exercises/modeling/automatic-feedback-view-detailed.png is excluded by !**/*.png, !**/*.png
📒 Files selected for processing (1)
  • docs/user/exercises/modeling.rst (1 hunks)
🔇 Additional comments (8)
docs/user/exercises/modeling.rst (8)

259-261: Section Header Formatting
The new "Automatic Student Feedback" section header is clear and uses an appropriate underline with dashes. Please verify that the underline length fully matches the header text per RST style requirements.


262-266: Effective Use of Admonition (Tip)
The admonition titled "Why Automatic Student Feedback" with the :class: tip is well implemented. It succinctly explains the benefits for large courses.


267-270: Overview Section Clarity
The "Overview:" block clearly outlines how preliminary AI feedback is requested and generated via the Athena Service. Ensure that the inline literal Allow automatic AI preliminary feedback requests is consistent with terminology used elsewhere in the documentation.


271-274: Emphasizing Key Recommendations with a Note
The note admonition emphasizing the need for comprehensive Grading Instructions and a Sample Solution is clear and informative. This guidance should help users align their configurations with intended grading criteria.


286-290: Figure Directive for Feedback Request Editor
The figure inclusion for the feedback request editor is well defined with appropriate alignment, alternative text, and scaling. Please verify that the referenced image exists in the assets and displays as intended on all target devices.


291-314: Detailed 'Viewing Feedback' Instructions
The "Viewing Feedback" section provides thorough, step-by-step instructions combined with multiple visual cues. The use of container directives and clear alt text in figure directives enhances user guidance.


331-335: Raw HTML Integration for Video Embed
Embedding the demo video via a raw HTML iframe is acceptable. Please ensure that the documentation hosting platform supports raw HTML content so that the iframe renders correctly across all browsers and devices.


337-357: Image Reference Consistency
The block defining image references is well organized and consistent with the rest of the documentation. This method of defining references promotes reuse and clarity throughout the document.

@LeonWehrhahn LeonWehrhahn changed the title Documentation: Automatic Student Feedback General: Automatic Student Feedback Documentation Feb 5, 2025
Copy link

@HanyangXu0508 HanyangXu0508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and worked as expected

Copy link

@sawys777 sawys777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear and easy to understand documentation, adding a red border around the preliminary score in (modeling/automatic-feedback-request-score.png) would be great to enhance its visuality.

Copy link

@simonbohnen simonbohnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@HawKhiem HawKhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is clear and concise

Copy link

@kevinfischer4 kevinfischer4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked for style, grammar and typos. Documentation looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Work In Progress
Development

Successfully merging this pull request may close these issues.

6 participants