Changed default of “hold” to true and removed need for rounding by de…

…fault
lprhodes · Apr 20, 2017 · 7304dd2 · 7304dd2
1 parent a32d4bb
commit 7304dd2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/accessories/windowCovering.js b/accessories/windowCovering.js
@@ -38,7 +38,7 @@ class WindowCoveringAccessory extends BroadlinkRMAccessory {
     if (!this.currentPosition) this.currentPosition = 0;
 
     let { percentageChangePerSend } = config;
-    if (!percentageChangePerSend) percentageChangePerSend = 10;
+    if (!percentageChangePerSend) percentageChangePerSend = 1;
 
     let difference = this.targetPosition - this.currentPosition;
 
@@ -76,7 +76,8 @@ class WindowCoveringAccessory extends BroadlinkRMAccessory {
     let { hold, percentageChangePerSend, interval, disableAutomaticOff, onDuration, onDurationOpen, onDurationClose, totalDurationOpen, totalDurationClose } = config;
     const { off } = data;
 
-    if (!interval) interval = 0.5;
+    if (interval === undefined) interval = 0.5;
+    if (hold === undefined) hold = true;
     if (!percentageChangePerSend) percentageChangePerSend = 10;
     if (disableAutomaticOff === undefined) disableAutomaticOff = true;
     if (!onDuration) onDuration = this.opening ? onDurationOpen : onDurationClose;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "homebridge-broadlink-rm",
-  "version": "1.3.8",
+  "version": "1.3.9",
   "description": "Broadlink RM plugin (including the mini and pro) for homebridge: https://github.com/nfarina/homebridge",
   "license": "ISC",
   "keywords": [