Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loyaltylion changes #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

loyaltylion changes #1

wants to merge 3 commits into from

Conversation

clarkdave
Copy link
Member

No description provided.

@clarkdave
use node Address instead of ServiceAddress
3443053 
our rabbitmq consul setup likes to set the ServiceAddress to be its own
node name, which is the internal dns record. this breaks the
expectations of cloud map, which wants IP addresses

we can use Node.Address here instead which will be the IP address of
the node, and therefore the service address too (we don't have multiple
network interfaces for our nodes)

this also changes the service instance ID to the node name, which we
know is unique and is easier to identify
@clarkdave
include tags in service names
9eed295 
by default, consul-aws only creates 1:1 services with those registered
in consul, but we leverage tags to distinguish between difference kinds
of service instances (e.g. primary and replica database nodes)

this change takes tags into account when creating the list of services,
resulting in one service per tag+service combination
@clarkdave
create a records in cloud map in addition to srv records
9559df6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangz frangz frangz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clarkdave @frangz