Skip to content

Commit

Permalink
Revert "Disable async serve handler in Ray Service cluster (ray-proje…
Browse files Browse the repository at this point in the history
…ct#447)" (ray-project#606)

This reverts commit eaa6790.

Why are these changes needed?
Ray 2.0 lets users build their Serve deployment graphs using async handles. However, KubeRay disables async handles by default. Once users build their deployment graphs, they attempt to use it with KubeRay but must add code changes to remove double await statements used with async handles. See Issue #28908 in the Ray repo for more info.

This change removes the logic that disables async handles in KubeRay.
  • Loading branch information
shrekris-anyscale authored Sep 29, 2022
1 parent 94b1c45 commit aa017cd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion ray-operator/controllers/ray/common/constant.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ const (
RAY_TIMEOUT_MS_TASK_WAIT_FOR_DEATH_INFO = "RAY_timeout_ms_task_wait_for_death_info"
RAY_GCS_SERVER_REQUEST_TIMEOUT_SECONDS = "RAY_gcs_server_request_timeout_seconds"
RAY_SERVE_KV_TIMEOUT_S = "RAY_SERVE_KV_TIMEOUT_S"
SERVE_DEPLOYMENT_HANDLE_IS_SYNC = "SERVE_DEPLOYMENT_HANDLE_IS_SYNC"
SERVE_CONTROLLER_PIN_ON_NODE = "RAY_INTERNAL_SERVE_CONTROLLER_PIN_ON_NODE"
RAY_USAGE_STATS_KUBERAY_IN_USE = "RAY_USAGE_STATS_KUBERAY_IN_USE"

Expand Down
4 changes: 0 additions & 4 deletions ray-operator/controllers/ray/common/pod.go
Original file line number Diff line number Diff line change
Expand Up @@ -571,10 +571,6 @@ func setContainerEnvVars(pod *v1.Pod, rayContainerIndex int, rayNodeType rayiov1
gcsTimeoutEnv := v1.EnvVar{Name: RAY_GCS_SERVER_REQUEST_TIMEOUT_SECONDS, Value: "5"}
container.Env = append(container.Env, gcsTimeoutEnv)
}
if !envVarExists(SERVE_DEPLOYMENT_HANDLE_IS_SYNC, container.Env) {
serveHandleSync := v1.EnvVar{Name: SERVE_DEPLOYMENT_HANDLE_IS_SYNC, Value: "1"}
container.Env = append(container.Env, serveHandleSync)
}
if !envVarExists(RAY_SERVE_KV_TIMEOUT_S, container.Env) {
serveKvTimeoutEnv := v1.EnvVar{Name: RAY_SERVE_KV_TIMEOUT_S, Value: "5"}
container.Env = append(container.Env, serveKvTimeoutEnv)
Expand Down

0 comments on commit aa017cd

Please sign in to comment.