Add CRD verb permission in helm (ray-project#144)

* add crd verb permission in helm * fix ray cluster volume * Update helm-chart/kuberay-operator/README.md Co-authored-by: Oliver Mannion <[email protected]> Co-authored-by: wuhua.ck <[email protected]> Co-authored-by: Oliver Mannion <[email protected]>
lowang-bh · Feb 7, 2022 · 442b291 · 442b291
1 parent 60ff45d
commit 442b291
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 13 deletions.
diff --git a/helm-chart/kuberay-operator/README.md b/helm-chart/kuberay-operator/README.md
@@ -16,6 +16,11 @@ version.BuildInfo{Version:"v3.6.2", GitCommit:"ee407bdf364942bcb8e8c665f82e15aa2
 
 ## Installing the Chart
 
+To avoid duplicate CRD definitions in this repo, we reuse CRD config in `ray-operator`:
+```console
+$ kubectl apply -k "../../ray-operator/config/crd"
+```
+
 Please use command below:
 ```console
 $ helm install kuberay-operator . --values values.yaml --namespace kuberay-operator --create-namespace

diff --git a/helm-chart/kuberay-operator/templates/role.yaml b/helm-chart/kuberay-operator/templates/role.yaml
@@ -48,4 +48,10 @@ rules:
   - get
   - list
   - watch
+- apiGroups:
+  - "ray.io"
+  resources:
+  - rayclusters
+  verbs:
+  - "*"
 {{- end }}
diff --git a/helm-chart/kuberay-operator/values.yaml b/helm-chart/kuberay-operator/values.yaml
@@ -6,7 +6,7 @@ replicaCount: 1
 
 image:
   repository: kuberay/operator
-  tag: v0.1.0
+  tag: nightly
   pullPolicy: IfNotPresent
 
 nameOverride: "kubray-operator"

diff --git a/helm-chart/ray-cluster/values.yaml b/helm-chart/ray-cluster/values.yaml
@@ -18,13 +18,11 @@ head:
     key: value
   initArgs:
     port: '6379'
-    object-manager-port: '12345'
-    node-manager-port: '12346'
-    object-store-memory: '100000000'
     redis-password: 'LetMeInRay'
     dashboard-host: '0.0.0.0'
     num-cpus: '1' # can be auto-completed from the limits
     node-ip-address: $MY_POD_IP # auto-completed as the head pod IP
+    block: 'true'
   containerEnv:
     - name: MY_POD_IP
       valueFrom:
@@ -37,15 +35,11 @@ head:
        cpu: 200m
   annotations: {}
   volumes:
-    - name: config
-      configMap:
-        name: ray-code
-        items:
-          - key: code.py
-            path: code.py
+    - name: log-volume
+      emptyDir: { }
   volumeMounts:
-    - mountPath: /opt
-      name: config
+    - mountPath: /tmp/ray
+      name: log-volume
 
 
 worker:
@@ -57,6 +51,7 @@ worker:
   initArgs:
     node-ip-address: $MY_POD_IP
     redis-password: LetMeInRay
+    block: 'true'
   containerEnv:
     - name: MY_POD_IP
       valueFrom:
@@ -90,7 +85,7 @@ worker:
     - name: log-volume
       emptyDir: {}
   volumeMounts:
-    - mountPath: /var/log
+    - mountPath: /tmp/ray
       name: log-volume
 
 headServiceSuffix: "ray-operator.svc"