Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[capture] Specify offset in clk cycles #177

Closed
vrozic opened this issue Oct 10, 2023 · 4 comments
Closed

[capture] Specify offset in clk cycles #177

vrozic opened this issue Oct 10, 2023 · 4 comments
Assignees
@johannheyszl
Labels
Priority:P0

Comments

@vrozic
Copy link
Contributor

vrozic commented Oct 10, 2023

At the moment, measurement offset in capture configuration files is specified in samples.
It probably makes more sense to use clk cycles of the target as a unit of measurement.
vrozic added a commit to vrozic/ot-sca that referenced this issue Oct 22, 2023
@vrozic
[capture] Specify offset in target clk cycles
6640b34 
Specify offset in target clock cycles, rather than number of
samples.
This commit resolves lowRISC#177

Signed-off-by: Vladimir Rozic <[email protected]>
@vogelpi
Copy link
Collaborator

vogelpi commented Oct 24, 2023

@vrozic is working on this and we've briefly discussed this today. Even if for the time being the computation of the offsets and number of samples / window size happens in / close to the scope code this would be okay. We can refine this later.

Ideally we have a first working version for this soon. We need this to re-enable captures with latest bitstreams (use different target clock frequencies on the CW310). My goal is to work on this in the second half of this week.

@vrozic vrozic mentioned this issue Oct 25, 2023
Merged
@vogelpi vogelpi self-assigned this Oct 30, 2023
@vogelpi
Copy link
Collaborator

vogelpi commented Oct 31, 2023

Update: we merged PR #203 which implements the corresponding changes in the CW-based setup. What's left to do is to align the WaveRunner implementation.

@vogelpi
Copy link
Collaborator

vogelpi commented Oct 31, 2023

I am thus un-assigning myself and @vrozic and instead assign @johannheyszl who might be able to take care of the WaveRunner part when returning to work.

@vogelpi vogelpi assigned johannheyszl and unassigned vogelpi and vrozic Oct 31, 2023
@johannheyszl
Copy link
Collaborator

has been addressed in #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johannheyszl johannheyszl

Labels
Priority:P0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vogelpi @vrozic @johannheyszl