Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pinmux] Remove some TODOs #6025

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Conversation

msfschaffner
Copy link
Contributor

@msfschaffner msfschaffner commented Apr 9, 2021

The first commit removes a tie-off array that is not needed anymore.

The second commit updates the strap sampling behavior in DFT-enabled LC states.
We also change the life cycle state for emulation and simulation environments from DEV to RMA in order to ungate all possible DFT and functional infrastructure.

@msfschaffner msfschaffner self-assigned this Apr 9, 2021
@msfschaffner msfschaffner changed the title [pinmux] Remove tie-off values TODO WIP [pinmux] Remove tie-off values TODO Apr 9, 2021
@msfschaffner msfschaffner changed the title WIP [pinmux] Remove tie-off values TODO WIP [pinmux] Remove TODOs and update docs Apr 9, 2021
@msfschaffner msfschaffner changed the title WIP [pinmux] Remove TODOs and update docs WIP [pinmux] Remove TODOs Apr 9, 2021
@msfschaffner msfschaffner force-pushed the remove-todos branch 2 times, most recently from 23f4a88 to 768fc0a Compare April 9, 2021 23:53
@msfschaffner msfschaffner marked this pull request as ready for review April 10, 2021 00:09
@msfschaffner msfschaffner added Component:RTL Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR and removed Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR labels Apr 10, 2021
@msfschaffner msfschaffner force-pushed the remove-todos branch 2 times, most recently from 45f1fd9 to 05e6160 Compare April 10, 2021 00:12
@msfschaffner msfschaffner changed the title WIP [pinmux] Remove TODOs [pinmux] Remove some TODOs Apr 10, 2021
@msfschaffner msfschaffner force-pushed the remove-todos branch 2 times, most recently from 2d88a46 to f15a5c2 Compare April 10, 2021 00:22
This does not seem to be necessary anymore.

Signed-off-by: Michael Schaffner <[email protected]>
This slightly modifies the strap sampling behavior in DFT-enabled
LC states. In particular, we now continously sample the straps in
those states, instead of gating the continous sampling mode
on whether the initial sample was nonzero or not.

This puts less burden on the emulation and simulation environments
where it the device can run in a DFT-enabled mode, since the
strap values may be changed arbitrarily during the test sequence.

This also changes the default life cycle state to RMA instead of DEV
for simulation and emulation environments to ungate all debug
infrastructure and functional modes.

Signed-off-by: Michael Schaffner <[email protected]>
@msfschaffner msfschaffner merged commit 17f4bf8 into lowRISC:master Apr 13, 2021
@msfschaffner msfschaffner deleted the remove-todos branch February 18, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants