[rom_ctrl, dv] Conditional coverage hole of rom_ctrl_mux #25798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KinzaQamar
requested review from
eshapira and
rswarbrick
and removed request for
a team and
eshapira
rom_ctrl coverage report contains a hole occurred in rom_ctrl_mux.sv by a conditional statement (alert_d = sel_invalid | sel_reverted | sel_q_reverted) as 001 not covered. This PR fixes corrupt_sig_fatal_vseq to force sel_bus_qq in rom_ctrl_mux to an invalid value to get sel_q_reverted = 1. Then to make sure that we inject something bad to sel_bus_qq before ROM check finishes, the fix adds force_early variable. Lastly, changed the name err_point to inject_after_done for better readibility. Signed-off-by: Kinza Qamar <[email protected]>
KinzaQamar
force-pushed
the
rom_ctrl_code_cov
branch
from
74866bf to
2a8182e
Compare
rswarbrick
reviewed
Jan 7, 2025
|
Duh, sorry! I'm convinced by this change after all. (For future me: There are three values A,B,C and we check A==B and B==C. We want to see each of those checks failing separately, so poking B won't help) |
rswarbrick
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rom_ctrl coverage report contains a hole occurred in rom_ctrl_mux.sv by a conditional statement (alert_d = sel_invalid | sel_reverted | sel_q_reverted) as 001 not covered.
This PR fixes corrupt_sig_fatal_vseq to force sel_bus_qq in rom_ctrl_mux to an invalid value to get sel_q_reverted = 1. Then to make sure that we inject something bad to sel_bus_qq before ROM check finishes, the fix adds force_early variable.
Lastly, changed the name err_point to inject_after_done for better readibility.