[ci] Use alternative mechanisms to avoid github API file limits #25744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the file number limit for `gh pr diff`, change to comparing the checkout against the base branch. Signed-off-by: Alexander Williams <[email protected]>
a-will
force-pushed
the
ci-work-with-file-limits
branch
from
d496514 to
6b89ea9
Compare
nbdd0121
reviewed
Dec 23, 2024
| @@ -22,7 +22,9 @@ jobs: | |||
| run: | | |||
| pr_url="https://github.com/${{ github.repository }}/pull/${{ github.event.number }}" | |||
| echo $pr_url | |||
| gh pr diff $pr_url --name-only > $HOME/changed_files | |||
| gh pr checkout $pr_url --name-only > $HOME/changed_files | |||
There was a problem hiding this comment.
Would it be better to change the checkout sha above to
with:
ref: refs/pull/${{ github.event.pull_request.number }}/merge
fetch-depth: 2 # include merge commit parents
which should allow direct diff without needing to checkout again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the file number limit for
gh pr diff, change to comparing the checkout against the base branch.