[spm] Make HSM assets configurable at the SKU level. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration file was used in older integration test cases. Remove as it is no longer used. Signed-off-by: Miguel Osorio <[email protected]>
Refactor the key loading mechanism so that the spm only loads assets specific to the SKU configuration provided at service instantiation. The following SKU configuration settings are introduced in this change: * `SymmetricKeys`: List of keys of `pk11.ClassSecretKey` type. * `PrivateKeys`: List of keys of `pk11.ClassPrivateKey` type. * `Certs`: List of certificates, including root and intermediate CA certificates. Signed-off-by: Miguel Osorio <[email protected]>
timothytrippel
approved these changes
Feb 4, 2025
| rootCAPath: certs/NuvotonTPMRootCA0200.cer | ||
| symmetricKeys: | ||
| - name: "HighSecKdfSeed" | ||
| - name: "LowSecKdfSeed" |
There was a problem hiding this comment.
I presume in a follow up you will load the Root CA, DICE ICA, and SKU-specific CA keys for this sku too?
There was a problem hiding this comment.
Yes, I will do it in the same PR that enables loadtest for EndorseCerts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the key loading mechanism so that the
spmonly loads assets specific to the SKU configuration provided
at service instantiation.
The following SKU configuration settings are introduced in this change:
SymmetricKeys: List of keys ofpk11.ClassSecretKeytype.PrivateKeys: List of keys ofpk11.ClassPrivateKeytype.Certs: List of certificates, including root and intermediate CAcertificates.