Use go.uber.org/mock/gomock #468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenniles
commented
Dec 1, 2024
| github.com/gorilla/mux v1.8.0 | ||
| github.com/hashicorp/go-multierror v1.1.1 | ||
| github.com/stretchr/testify v1.8.4 | ||
| github.com/syndtr/goleveldb v1.0.0 | ||
| go.uber.org/mock v0.4.0 |
There was a problem hiding this comment.
Version v0.4.0 of go.uber.org/mock is the latest release compatible with the Go version specified in our go.mod file (1.20). Upgrading beyond v0.4.0 would require us to update the go directive to a newer Go version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I’ve replaced
github.com/golang/mock/gomockwithgo.uber.org/mock/gomock. The original repository, github.com/golang/mock, appears to be unmaintained since June 2023. Its README recommends switching to Uber's fork, which is actively maintained.