Fix clone functions of InputStats and OutputStats to prevent data race condition #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frairon
approved these changes
Nov 28, 2022
|
good catch, many thanks for the fix! |
mmreza79
approved these changes
Nov 28, 2022
|
Thanks! Can you please allow this PR to be merged into master? |
|
really sorry for the delay, things got out of sight over here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&(*x)doesn't clone the data (that pattern has used for theclone()function forgoka.InputStatsandgoka.OutputStats) into a new instance because it is simplified tox. (This can be detected by staticcheck SA4001) So, it has made data race condition when a cloned stats is used. We have observed this in Goka web monitor and other places where it is usingView.Stats.This can be reproduced with a goka web monitor enabled application by turning on the Go race detector
-race.