inherit debug logging to custom loggers, fixes issue #382

logger.go

@@ -9,15 +9,12 @@ import (
 	"github.com/Shopify/sarama"
 )
 
-var (
-	defaultLogger = &std{
-		log: log.New(os.Stderr, "", log.LstdFlags),
-	}
-)
+var defaultLogger = &std{
+	log: log.New(os.Stderr, "", log.LstdFlags),
+}
 
 // Logger is the interface Goka and its subpackages use for logging.
 type Logger interface {
-
 	// Print will simply print the params
 	Print(...interface{})
 
@@ -53,6 +50,7 @@ type std struct {
 func (s *std) Print(msgs ...interface{}) {
 	s.log.Print(msgs...)
 }
+
 func (s *std) Println(msgs ...interface{}) {
 	s.log.Print(msgs...)
 }
@@ -77,6 +75,7 @@ func DefaultLogger() Logger {
 }
 
 // Debug enables or disables debug logging using the global logger.
+// The goka debugging setting is applied to any custom loggers in goka components (Processors, Views, Emitters).
 func Debug(gokaDebug, saramaDebug bool) {
 	defaultLogger.debug = gokaDebug
 	if saramaDebug {
@@ -89,15 +88,17 @@ func SetSaramaLogger(logger Logger) {
 }
 
 // newLogger creates a new goka logger
-func wrapLogger(l Logger) logger {
+func wrapLogger(l Logger, debug bool) logger {
 	return &std{
-		log: l,
+		log:   l,
+		debug: debug,
 	}
 }
 
 func (s *std) CurrentPrefix() string {
 	return s.prefix
 }
+
 func (s *std) StackPrefix(prefix string) logger {
 	var prefPath []string
 	// append existing path

options.go

@@ -85,7 +85,6 @@ func DefaultHasher() func() hash.Hash32 {
 	return func() hash.Hash32 {
 		return fnv.New32a()
 	}
-
 }
 
 // DefaultUpdateContext implements the UpdateContext interface.
@@ -221,7 +220,7 @@ func WithLogger(l Logger) ProcessorOption {
 		if prefixLogger, ok := l.(logger); ok {
 			o.log = prefixLogger
 		} else {
-			o.log = wrapLogger(l)
+			o.log = wrapLogger(l, defaultLogger.debug)
 		}
 	}
 }
@@ -406,7 +405,7 @@ func WithViewLogger(l Logger) ViewOption {
 		if prefixLogger, ok := l.(logger); ok {
 			o.log = prefixLogger
 		} else {
-			o.log = wrapLogger(l)
+			o.log = wrapLogger(l, defaultLogger.debug)
 		}
 	}
 }
@@ -555,7 +554,7 @@ func WithEmitterLogger(l Logger) EmitterOption {
 		if prefixLogger, ok := l.(logger); ok {
 			o.log = prefixLogger
 		} else {
-			o.log = wrapLogger(l)
+			o.log = wrapLogger(l, defaultLogger.debug)
 		}
 	}
 }