github action for installing goka #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frairon
force-pushed
the
action-install-goka
branch
12 times, most recently
from
ff11c84 to
3800bb2
Compare
frairon
force-pushed
the
action-install-goka
branch
from
3800bb2 to
c64c2be
Compare
juandes
previously approved these changes
Mar 10, 2022
frairon
force-pushed
the
action-install-goka
branch
from
ff3b9d6 to
6a20b55
Compare
frairon
commented
Apr 4, 2022
| return proc1.Run(ctx) | ||
| // simulatenously stopping multiple processors sometimes fails the processors, so this one gets delayed | ||
| // see issue #376 for details | ||
| return proc1.Run(DelayedCtxCloser(ctx, 5*time.Second)) |
There was a problem hiding this comment.
workaround to make the test more stable: avoid shutting down the processors simultaneously
frairon
commented
Apr 4, 2022
|
|
||
| err = tm.EnsureStreamExists(inputStream, 1) | ||
| test.AssertNil(t, err) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
this test was flaky altogether, because it created the wrong topic, which ended up with two topics having two different number of partitions, as the examples-cluster was configured with "auto-create:true". This is fixed now and yields two new issues:
- fix all examples that depend on "auto-create:true" (create actions for examples #379)
- detect partition mismatches (check partition mismatch #378)
frairon
force-pushed
the
action-install-goka
branch
from
6a20b55 to
06a6eaa
Compare
frairon
force-pushed
the
action-install-goka
branch
from
06a6eaa to
0618db7
Compare
jomaresch
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves testing of goka
testify