Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmitSyncWithHeaders emitter method #271

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

adw1n
Copy link
Contributor

@adw1n adw1n commented Sep 21, 2020

Being able to emit with headers is important to people who use tracing.

@adw1n adw1n changed the title Add EmitWithHeadersSync emitter method Add EmitSyncWithHeaders emitter method Sep 21, 2020
@adw1n
Copy link
Contributor Author

adw1n commented Sep 29, 2020

@R053NR07 @frairon please could you review this PR?

@frairon frairon merged commit f26d361 into lovoo:master Sep 29, 2020
@frairon
Copy link
Contributor

frairon commented Sep 29, 2020

Thanks a lot @adw1n for the contribution (and the reminder), sorry for the long delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants