Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku docs: Add VIPS buildpack dependencies #2992

Closed
wants to merge 1 commit into from

Conversation

josephfrazier
Copy link

@josephfrazier josephfrazier commented Nov 28, 2021

I used https://github.com/brandoncc/heroku-buildpack-vips to install VIPS in my heroku app, and discovered that I needed to install some extra packages to get it working. I opened up a PR on that repo, but then realized that it might be more relevant here.

There's some related documentation here: https://gist.github.com/bigtiger/be41fffcd103d7e98c5fe4fdff0af3f9

I used https://github.com/brandoncc/heroku-buildpack-vips to install VIPS in my heroku app, and discovered that I needed to install some extra packages to get it working. I opened up a PR on that repo, but then realized that it might be more relevant here.
@lovell
Copy link
Owner

lovell commented Nov 28, 2021

Hi, thanks for the PR, as far as I know the buildpack you reference isn't required to use sharp on Heroku. Is my understanding correct?

@josephfrazier
Copy link
Author

If I recall correctly, sharp bundles VIPS by default, so it's not generally required. However, my use case involves decoding HEIC images, so I needed to install it separately. Maybe I should make that clearer in the docs?

@lovell
Copy link
Owner

lovell commented Nov 29, 2021

Thanks for confirming. Given this is not a requirement to install sharp on Heroku, I'd prefer not to mention it in the sharp docs otherwise people will get confused and I'll end up fielding support questions relating to its maintenance that I can't help with.

In addition, this buildpack is one of many forks of https://github.com/alex88/heroku-buildpack-vips/network/members all with slightly differing dependencies and installation requirements and I'd prefer if each of these were self documenting rather than trying to cover every possible combination in the sharp docs.

Perhaps you could maintain an active fork that is well-documented and explicitly mentions sharp. If so, you should highlight that your buildpack makes all code running in it GPL (e.g. poppler, fftw). It's also worth noting that if you're planning to distribute binaries that can en/docode HEIC then you will be subject to HEVC patent claims.

@josephfrazier
Copy link
Author

Thanks for the detailed response, I see why you wouldn't want to put these docs here, and agree that a fork might be a better place for me to put them. Also appreciate the reminder about HEVC patent claims! I'll go ahead and close this, thanks again for the consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants