-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: link libvips with -Bsymbolic-functions #60
Comments
Nice idea, happy for a PR if you're able. This is an ELF-only feature so should be ignored by linkers for e.g. macOS targets. |
Great, I'll prepare a PR. Ah, you're right, this linker flag only applies to ELF binaries and not to Mach-O, for example. I got confused since HarfBuzz seems to configure successfully with
|
(Re-opening auto-closed issue until we publish a new release.) |
At @lovell's suggestion, I've just opened electron/electron#25495 (which may help other native modules). Please tell me if I should edit the issue in any way to clarify or fix and mistakes. |
See kleisauke@41fb70c and kleisauke/net-vips#90 for context. Could possibly resolve lovell/sharp#575 (and other
node-canvas
related issues).GLib uses this linker flag by default, so it might make sense to also link libvips with this flag. The above NetVips issue had no issues running this on macOS, so I'm not sure if this flag is needed there as well (Homebrew also seems to avoid any
-Bsymbolic*
linker flags, probably due to missing support for this in Xcode(?)).The text was updated successfully, but these errors were encountered: