This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
resource monitor: add support for interval attribute #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @louy may I know that this PR is feasible to be merged :) |
|
Hi @nhamlh, Thanks for contributing! Sorry I didn’t get a notification about this for some reason. Looks good but there might be a need for a minor change or two. I’ll take a closer look tonight. |
|
Would you be able to add a test case for setting a custom interval? |
|
Sure @louy. However I'm not familiar with terraform test package yet so it would take me sometime to write the test :D |
|
I've added a test here and merged your change. Thanks for contributing :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.