This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
Websocket Fix #303
Merged
Websocket Fix #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http2FancyWriter does not implement the http.Hijacker method causing the websocket upgrade to throw an exception. This PR fixes the issues by forcing the selection of httpFancyWriter{}
gambol99
force-pushed
the
websocket_fix
branch
from
2503406 to
a423ab8
Compare
|
tested and works like a charm |
|
awesome! ... thanks for testing @aalubin :-) |
Closed
gambol99
added a commit
that referenced
this pull request
Feb 12, 2018
FEATURES: * Added the groups parameter to the resource, permitting users to use the jest docker ecryptfs dev claim in the token [#PR301](#301) * Removed the authors file [#PR299](#299) FIXES: * Fixed the custom headers when upgrading to websockets [#PR311](#311) * Fixed exception when upgrading to websockets [#PR303](#303)
Merged
gambol99
added a commit
that referenced
this pull request
Feb 12, 2018
FEATURES: * Added the groups parameter to the resource, permitting users to use the jest docker ecryptfs dev claim in the token [#PR301](#301) * Removed the authors file [#PR299](#299) FIXES: * Fixed the custom headers when upgrading to websockets [#PR311](#311) * Fixed exception when upgrading to websockets [#PR303](#303)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http2FancyWriter does not implement the http.Hijacker method causing the websocket upgrade to throw an exception. This PR fixes the issues by forcing the selection of httpFancyWriter{}