Fix issue with dlists referencing offsets outside of their own file #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEstelami
reviewed
Jan 13, 2024
| word0 = 0; | ||
| word1 = 0; | ||
| spdlog::error(StringHelper::Sprintf("dListDecl == nullptr! Addr = {:08X}", GETSEGOFFSET(data))); | ||
| uint32_t seg = data & 0xFFFFFFFF; |
There was a problem hiding this comment.
These changes look good but could you add a comment explaining its purpose? Something like // If we can't find the display list in this file, try looking in other files based on the segment number
garrettjoecox
force-pushed
the
fix-branch-lists
branch
from
9e34019 to
51a2334
Compare
louist103
pushed a commit
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes swords, and probably some other things