fix sample exporting #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
louist103
force-pushed
the
sample-fix
branch
from
f0d099c to
b04a6c5
Compare
Archez
approved these changes
Sep 29, 2024
louist103
added a commit
that referenced
this pull request
Jan 11, 2025
* WIP * Fix spelling * Fix mac * Fix binary for V2 * fix sample exporting (#31) * Sample XMLs. Needs importer to test * Fix names * fix sample exporting * Cleanups * Fix mac * fix binary samples * Update for torch format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See louist103/ZAPDTR#20 . Samples were not being exported correctly due to issues with loop offsets and names. This PR also changes how samples are named adding the bank ID to the file name.