Fix version file buffers not staying alive during o2r unload close #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspectredc
pushed a commit
to inspectredc/OTRExporter
that referenced
this pull request
Jun 16, 2024
louist103
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o2r archives using libzip requires that all buffers used with
AddFileare maintained alive until the archive is unloaded. Otherwise the unload will write garbage data for those files.the
versionandportVersionmemory streams were returning temporary vector pointers or something, and the o2r was unloaded outside of the if block where the version stream is, so it was being destructed after the stream.This addresses o2r archives showing as "unknown" game versions on the boot info.