Fix: Fix worker_threads support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprise, I think this is the only change needed to get it working!
In node-sqlite3#1367, you can see that they already fixed it by implementing
NAPI v6. Then in node-sqlite3#1444, you can see that they delayed deploying this fix only because their build process is broken. Since we don't need to support older node versions, we can just skip building forNAPI v3entirely.I tested a few add / delete monitor in uptime-kuma and the v6 version seems to work fine.
npm run testalso passed, although I'm not sure how the tests work.Closes uptime-kuma#574