fix(docs): cover sonarcloud code smells

Dockerfile

@@ -14,4 +14,4 @@ RUN echo "" > .env
 
 USER bot
 
-CMD node /app/dist/index.js $ENV_FILE
+CMD node /app/dist/index.js "$ENV_FILE"

src/helpers/cache/save-post-to-cache.ts

@@ -1,7 +1,19 @@
-import { BlueskyCache, Cache, MastodonCache,Platform } from '../../types/index.js';
+import { BlueskyCache, Cache, MastodonCache, Platform } from '../../types/index.js';
 import { updateCacheFile } from './update-cache.js';
 
-export const savePostToCache = async (cache:Cache,tweetId: string = '', data: MastodonCache | BlueskyCache, platform: Platform) => {
+interface PostToCache {
+    cache: Cache,
+    data: MastodonCache | BlueskyCache,
+    tweetId?: string,
+    platform: Platform
+}
+
+export const savePostToCache = async ({
+    cache,
+    tweetId = '',
+    data,
+    platform
+}: PostToCache) => {
     const alreadyExistingCachedPostData = cache[tweetId] || {};
     await updateCacheFile({
         ...cache,

src/helpers/tweet/get-tweet-id-from-permalink.ts

@@ -1 +1,3 @@
-export const getTweetIdFromPermalink = (url: string): string => url.match(/\d{19}$/)?.[0] || '';
+export const getTweetIdFromPermalink = (url: string): string => {
+    return url.match(/\d{19}$/)?.[0] ?? '';
+};

src/helpers/url/get-redirection.ts

@@ -4,7 +4,7 @@ export const getRedirectedUrl = async(url: string): Promise<string | null> => {
 
         if (response.status >= 300 && response.status < 400) {
             const redirectedUrl = response.headers.get('location');
-            return redirectedUrl || null;
+            return redirectedUrl ?? null;
         }
 
         return null;

src/services/bluesky-sender.service.ts

@@ -79,7 +79,10 @@ export const blueskySenderService = async (client: BskyAgent | null, post: Blues
                 $type: 'app.bsky.embed.recordWithMedia',
                 media: {
                     $type: 'app.bsky.embed.images',
-                    images: mediaAttachments.length ? mediaAttachments.map(i => ({ alt: i.alt_text ?? '', image: i.data.blob.original })) : undefined
+                    images: mediaAttachments.length ? mediaAttachments.map(i => ({
+                        alt: i.alt_text ?? '',
+                        image: i.data.blob.original
+                    })) : undefined
                 },
                 record: {
                     $type: 'app.bsky.embed.record',
@@ -114,7 +117,10 @@ export const blueskySenderService = async (client: BskyAgent | null, post: Blues
         if (mediaAttachments.length) {
             data.embed = {
                 $type: 'app.bsky.embed.images',
-                images: mediaAttachments.length ? mediaAttachments.map(i => ({ alt: i.alt_text ?? '', image: i.data.blob.original })) : undefined
+                images: mediaAttachments.length ? mediaAttachments.map(i => ({
+                    alt: i.alt_text ?? '',
+                    image: i.data.blob.original
+                })) : undefined
             };
         }
     }
@@ -125,9 +131,14 @@ export const blueskySenderService = async (client: BskyAgent | null, post: Blues
     await client.post({ ...data }).then(async (createdPost) => {
         log.succeed(`☁️ | post sent: ${getPostExcerpt(post.tweet.text ?? VOID)}`);
         const cache = await getCache();
-        await savePostToCache(cache, post.tweet.id, {
-            cid: createdPost.cid,
-            rkey: createdPost.uri.match(/\/(?<rkey>\w+)$/)?.groups?.['rkey'] || ''
-        }, Platform.BLUESKY);
+        await savePostToCache({
+            cache,
+            tweetId: post.tweet.id,
+            data: {
+                cid: createdPost.cid,
+                rkey: createdPost.uri.match(/\/(?<rkey>\w+)$/)?.groups?.['rkey'] || ''
+            },
+            platform: Platform.BLUESKY
+        });
     });
 };

src/services/mastodon-sender.service.ts

@@ -15,7 +15,7 @@ const BLUESKY_MEDIA_IMAGES_MAX_COUNT = 4;
  * An async method in charge of handling Mastodon posts computation & uploading
  */
 export const mastodonSenderService = async (client: mastodon.rest.Client | null, post: MastodonPost | null, medias: Media[], log: Ora) => {
-    if(!client || !post) {
+    if (!client || !post) {
         return;
     }
 
@@ -50,7 +50,7 @@ export const mastodonSenderService = async (client: mastodon.rest.Client | null,
     }
 
     // When no compatible media has been found and no text is present, skip the post
-    if(!mediaAttachments.length && !post.tweet.text) {
+    if (!mediaAttachments.length && !post.tweet.text) {
         log.warn(`🦣️ | post skipped: no compatible media nor text to post (tweet: ${post.tweet.id})`);
         return;
     }
@@ -67,6 +67,6 @@ export const mastodonSenderService = async (client: mastodon.rest.Client | null,
         .then(async (toot) => {
             log.succeed(`🦣 | toot sent: ${getPostExcerpt(post.tweet.text ?? VOID)}`);
             const cache = await getCache();
-            await savePostToCache(cache, post.tweet.id, toot.id, Platform.MASTODON);
+            await savePostToCache({ cache, tweetId: post.tweet.id, data: toot.id, platform: Platform.MASTODON });
         });
 };

src/services/tweets-getter.service.ts

@@ -30,38 +30,37 @@ export const tweetsGetterService = async (twitterClient: Scraper): Promise<Tweet
     let hasRateLimit = false;
     for await(const tweet of tweetsIds) {
         const rateLimitTimeout = setTimeout(() => hasRateLimit = true,1000 * API_RATE_LIMIT);
-        if(hasRateLimit) {
+        if(hasRateLimit || isTweetCached(tweet, cache)) {
             continue;
         }
-        if (tweet && !isTweetCached(tweet, cache)) {
-            const t: Tweet = {
-                ...tweet,
-                id: getTweetIdFromPermalink(tweet.id || ''),
-                timestamp: (tweet.timestamp ?? 0) * 1000,
-                text: formatTweetText(tweet)
-            };
 
-            // Inject quoted tweet
-            if (tweet.quotedStatusId) {
-                const quotedStatus = await twitterClient.getTweet(tweet.quotedStatusId);
-                if (quotedStatus) {
-                    t.quotedStatus = quotedStatus;
-                }
-            }
+        const t: Tweet = {
+            ...tweet,
+            id: getTweetIdFromPermalink(tweet.id || ''),
+            timestamp: (tweet.timestamp ?? 0) * 1000,
+            text: formatTweetText(tweet)
+        };
 
-            // Inject in reply tweet
-            if (tweet.inReplyToStatusId) {
-                const inReplyStatus = await twitterClient.getTweet(tweet.inReplyToStatusId);
-                if (inReplyStatus) {
-                    t.inReplyToStatus = inReplyStatus;
-                }
+        // Inject quoted tweet
+        if (tweet.quotedStatusId) {
+            const quotedStatus = await twitterClient.getTweet(tweet.quotedStatusId);
+            if (quotedStatus) {
+                t.quotedStatus = quotedStatus;
             }
+        }
 
-            const eligibleTweet = await getEligibleTweet(t);
-            if (eligibleTweet) {
-                tweets.unshift(eligibleTweet);
+        // Inject in reply tweet
+        if (tweet.inReplyToStatusId) {
+            const inReplyStatus = await twitterClient.getTweet(tweet.inReplyToStatusId);
+            if (inReplyStatus) {
+                t.inReplyToStatus = inReplyStatus;
             }
         }
+
+        const eligibleTweet = await getEligibleTweet(t);
+        if (eligibleTweet) {
+            tweets.unshift(eligibleTweet);
+        }
         clearTimeout(rateLimitTimeout);
     }
 

src/types/media.ts

@@ -2,4 +2,4 @@ import { ComAtprotoRepoUploadBlob } from '@atproto/api';
 import { Photo, Video } from '@the-convocation/twitter-scraper/dist/tweets.js';
 
 export type Media = Photo & { type: 'image' } | Video & { type: 'video' }
-export type BlueskyMediaAttachment = ComAtprotoRepoUploadBlob.Response & { alt_text?: string | undefined}
+export type BlueskyMediaAttachment = ComAtprotoRepoUploadBlob.Response & { alt_text?: string}

src/types/post.ts

@@ -13,8 +13,8 @@ export type BlueskyPost = {
     status: string,
     username: string,
     facets?: Facet[],
-    quotePost?: { uri: string; cid: string; value: AppBskyFeedPost.Record } | undefined
-    replyPost?: { uri: string; cid: string; value: AppBskyFeedPost.Record } | undefined
+    quotePost?: { uri: string; cid: string; value: AppBskyFeedPost.Record }
+    replyPost?: { uri: string; cid: string; value: AppBskyFeedPost.Record }
 }
 
 export type Post = {